Fix sql port in admin tools when not provided#828
Merged
robholland merged 6 commits intotemporalio:mainfrom Jan 27, 2026
Merged
Conversation
|
|
|
|
Contributor
|
I'd prefer we fail the chart if they don't provide a port number, rather than us providing default ports. It is not unreasonable to require a port number. |
Contributor
Author
|
@robholland fixed it to fail if port isn't provided let me know if any other changes are required |
robholland
requested changes
Jan 22, 2026
remove helper function inline check directly in admin tools
robholland
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This change try to set the correct SQL_PORT when using sql plugin and providing an address like my-db.endpoint.com without a port.
Current implementation sets the port to my-db.endpoint.com since it tries to use the last part after : and there is only one part
Why?
default port can be assumed and it is better than invalid port which is current implementation
manually
not sure